Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] refactored assoc extension datamodel, #135 #136

Merged
merged 8 commits into from
Jan 30, 2018
Merged

[WIP] refactored assoc extension datamodel, #135 #136

merged 8 commits into from
Jan 30, 2018

Conversation

cmungall
Copy link
Contributor

No description provided.

@cmungall cmungall changed the title [WIP] refactored for gaf parsing, #135 [WIP] refactored assoc extension datamodel, #135 Jan 25, 2018
@cmungall
Copy link
Contributor Author

model is now disjunctive normal form. Previously was list of rel expressions. Now a dict, top level keyed by union_of, which is a list of expressions to be ORed. Each such expression is an object keyed by intersection_of, which is a list of expressions to be ANDed

This now reflects the complete expression in the gaf, for grammar see appendix of http://doi.org/10.1186/1471-2105-15-155

example

'union_of': [
   {'intersection_of':[ 
       {property:P1, filler:F1},
        ...
      ]
    },
    ...
]

cmungall
cmungall commented Jan 25, 2018
View reviewed changes
Copy link
Contributor Author

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok

@cmungall
Copy link
Contributor Author

shall we go ahead and merge this?

@dougli1sqrd
Copy link
Contributor

sure. Have we looked at the rdf portion? I can run some rdf generation too

@dougli1sqrd
Copy link
Contributor

Yeah let's merge this. I'll perform another ontobio release

@dougli1sqrd dougli1sqrd merged commit 7c822ec into master Jan 30, 2018
@dougli1sqrd dougli1sqrd deleted the issue-135 branch January 30, 2018 23:35
@dustine32 dustine32 mentioned this pull request Apr 4, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougli1sqrd dougli1sqrd Awaiting requested review from dougli1sqrd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmungall @dougli1sqrd