Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply mypy typing checker to all files #186

Closed
SagiPolaczek opened this issue Oct 3, 2022 · 1 comment
Closed

Apply mypy typing checker to all files #186

SagiPolaczek opened this issue Oct 3, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs

Comments

@SagiPolaczek
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
As described here, we use black, flake8 and mypy to enforce certain format criteria.
Currently we are ignoring some of the issues and some of files for the mypy checker. See ./.mypy.ini file for more details.

Describe the solution you'd like
Apply static typing in the ignored files so mypy will pass without ignoring any files (or at least much smaller amount).

NOTES

  1. NO LOGIC SHOULD BE CHANGED. Only the static typing according the functions/classes properties.
  2. This task might take too much time and effort in one-shot, so it can be done in a small doses - each PR with some amount of files fixed.
@SagiPolaczek SagiPolaczek added enhancement New feature or request good first issue Good for newcomers up-for-grabs labels Oct 3, 2022
@SagiPolaczek
Copy link
Collaborator Author

Solved in #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs
Projects
None yet
Development

No branches or pull requests

1 participant