fix(supicious/noDoubleEquals): fix typo (#2006)

Co-authored-by: ty <62130798+togami2864@users.noreply.github.com>
biomejs · Mar 9, 2024 · 2eecefb · 2eecefb
1 parent dfe676c
commit 2eecefb
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 34 deletions.
diff --git a/crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/lint_vue_js_files.snap b/crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/lint_vue_js_files.snap
@@ -44,7 +44,7 @@ file.vue:1:3 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━━━
     2 │ delete a.c;
     3 │ 
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use ===
   
@@ -105,5 +105,3 @@ file.vue:4:1 lint/style/noVar  FIXABLE  ━━━━━━━━━━━━━
 Checked 1 file in <TIME>. No fixes needed.
 Found 4 errors.
 ```
-
-
diff --git a/crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/lint_vue_ts_files.snap b/crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/lint_vue_ts_files.snap
@@ -44,7 +44,7 @@ file.vue:1:3 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━━━
     2 │ delete a.c;
     3 │ 
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use ===
   
@@ -123,5 +123,3 @@ file.vue:4:1 lint/style/noVar  FIXABLE  ━━━━━━━━━━━━━
 Checked 1 file in <TIME>. No fixes needed.
 Found 5 errors.
 ```
-
-
diff --git a/crates/biome_js_analyze/src/analyzers/suspicious/no_double_equals.rs b/crates/biome_js_analyze/src/analyzers/suspicious/no_double_equals.rs
@@ -15,7 +15,7 @@ declare_rule! {
     /// Require the use of `===` and `!==`
     ///
     /// It is generally bad practice to use `==` for comparison instead of
-    /// `===`. Double operators will triger implicit [type coercion](https://developer.mozilla.org/en-US/docs/Glossary/Type_coercion)
+    /// `===`. Double operators will trigger implicit [type coercion](https://developer.mozilla.org/en-US/docs/Glossary/Type_coercion)
     /// and are thus not prefered. Using strict equality operators is almost
     /// always best practice.
     ///
@@ -96,7 +96,7 @@ impl Rule for NoDoubleEquals {
         .detail(op.text_trimmed_range(), markup! {
             <Emphasis>{text_trimmed}</Emphasis>" is only allowed when comparing against "<Emphasis>"null"</Emphasis>
         }).note(markup! {
-            "Using "<Emphasis>{suggestion}</Emphasis>" may be unsafe if you are relying on type coercion"
+            "Using "<Emphasis>{text_trimmed}</Emphasis>" may be unsafe if you are relying on type coercion"
         })
         .description(description))
     }

diff --git a/crates/biome_js_analyze/tests/specs/suspicious/noDoubleEquals/invalid.js.snap b/crates/biome_js_analyze/tests/specs/suspicious/noDoubleEquals/invalid.js.snap
@@ -49,7 +49,7 @@ invalid.js:3:5 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━━━
     4 │ `;
     5 │ 
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use ===
   
@@ -77,7 +77,7 @@ invalid.js:7:3 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━━━
     8 │ 
     9 │ if (a == b) {
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use ===
   
@@ -107,7 +107,7 @@ invalid.js:9:7 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━━━
     10 │     false;
     11 │ }
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use ===
   
@@ -135,7 +135,7 @@ invalid.js:14:11 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━━
     15 │ 
     16 │     }
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use ===
   
@@ -163,13 +163,11 @@ invalid.js:19:34 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━━
     20 │   linter: ${linter}
     21 │ `;
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use ===
   
     19 │ ··formatter·enabled:·${formatter·===·true}
        │                                    +      
 
 ```
-
-
diff --git a/crates/biome_js_analyze/tests/specs/suspicious/noDoubleEquals/invalid.jsonc.snap b/crates/biome_js_analyze/tests/specs/suspicious/noDoubleEquals/invalid.jsonc.snap
@@ -21,7 +21,7 @@ invalid.jsonc:1:18 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━
   > 1 │ const isZero = a == 0;
       │                  ^^
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use ===
   
@@ -49,13 +49,11 @@ invalid.jsonc:1:21 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━
   > 1 │ const isNonZero = a != 0;
       │                     ^^
   
-  i Using !== may be unsafe if you are relying on type coercion
+  i Using != may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use !==
   
     1 │ const·isNonZero·=·a·!==·0;
       │                       +   
 
 ```
-
-
diff --git a/crates/biome_js_analyze/tests/specs/suspicious/noDoubleEquals/invalid.jsx.snap b/crates/biome_js_analyze/tests/specs/suspicious/noDoubleEquals/invalid.jsx.snap
@@ -35,13 +35,11 @@ invalid.jsx:3:51 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━━━
     4 │     style="color: red"
     5 │ >
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Unsafe fix: Use ===
   
     3 │ ····onClick={(event)·=>·console.log(event.ctrlKey·===·true)}
       │                                                     +       
 
 ```
-
-
diff --git a/crates/biome_js_analyze/tests/suppression/suspicious/noDoubleEquals/noDoubleEquals.js.snap b/crates/biome_js_analyze/tests/suppression/suspicious/noDoubleEquals/noDoubleEquals.js.snap
@@ -49,7 +49,7 @@ noDoubleEquals.js:3:5 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━
     4 │ `;
     5 │ 
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Safe fix: Suppress rule lint/suspicious/noDoubleEquals
   
@@ -83,7 +83,7 @@ noDoubleEquals.js:7:3 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━
     8 │ 
     9 │ if (a == b) {
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Safe fix: Suppress rule lint/suspicious/noDoubleEquals
   
@@ -117,7 +117,7 @@ noDoubleEquals.js:9:7 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━
     10 │     false;
     11 │ }
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Safe fix: Suppress rule lint/suspicious/noDoubleEquals
   
@@ -149,7 +149,7 @@ noDoubleEquals.js:14:11 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━
     15 │ 
     16 │     }
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Safe fix: Suppress rule lint/suspicious/noDoubleEquals
   
@@ -183,7 +183,7 @@ noDoubleEquals.js:19:34 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━
     20 │   linter: ${linter}
     21 │ `;
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Safe fix: Suppress rule lint/suspicious/noDoubleEquals
   
@@ -197,5 +197,3 @@ noDoubleEquals.js:19:34 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━
   
 
 ```
-
-
diff --git a/crates/biome_js_analyze/tests/suppression/suspicious/noDoubleEquals/noDoubleEquals.jsx.snap b/crates/biome_js_analyze/tests/suppression/suspicious/noDoubleEquals/noDoubleEquals.jsx.snap
@@ -35,7 +35,7 @@ noDoubleEquals.jsx:3:51 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━
     4 │     style="color: red"
     5 │ >
   
-  i Using === may be unsafe if you are relying on type coercion
+  i Using == may be unsafe if you are relying on type coercion
   
   i Safe fix: Suppress rule lint/suspicious/noDoubleEquals
   
@@ -49,5 +49,3 @@ noDoubleEquals.jsx:3:51 lint/suspicious/noDoubleEquals  FIXABLE  ━━━━━
   
 
 ```
-
-
diff --git a/website/src/content/docs/linter/rules/no-double-equals.md b/website/src/content/docs/linter/rules/no-double-equals.md
@@ -13,7 +13,7 @@ Source: <a href="https://eslint.org/docs/latest/rules/eqeqeq" target="_blank"><c
 Require the use of `===` and `!==`
 
 It is generally bad practice to use `==` for comparison instead of
-`===`. Double operators will triger implicit [type coercion](https://developer.mozilla.org/en-US/docs/Glossary/Type_coercion)
+`===`. Double operators will trigger implicit [type coercion](https://developer.mozilla.org/en-US/docs/Glossary/Type_coercion)
 and are thus not prefered. Using strict equality operators is almost
 always best practice.
 
@@ -42,7 +42,7 @@ foo == bar
    <strong>   │ </strong>    <strong><span style="color: Tomato;">^</span></strong><strong><span style="color: Tomato;">^</span></strong>
     <strong>2 │ </strong>
 
-<strong><span style="color: lightgreen;">  </span></strong><strong><span style="color: lightgreen;">ℹ</span></strong> <span style="color: lightgreen;">Using </span><span style="color: lightgreen;"><strong>===</strong></span><span style="color: lightgreen;"> may be unsafe if you are relying on type coercion</span>
+<strong><span style="color: lightgreen;">  </span></strong><strong><span style="color: lightgreen;">ℹ</span></strong> <span style="color: lightgreen;">Using </span><span style="color: lightgreen;"><strong>==</strong></span><span style="color: lightgreen;"> may be unsafe if you are relying on type coercion</span>
 
 <strong><span style="color: lightgreen;">  </span></strong><strong><span style="color: lightgreen;">ℹ</span></strong> <span style="color: lightgreen;">Unsafe fix</span><span style="color: lightgreen;">: </span><span style="color: lightgreen;">Use </span><span style="color: lightgreen;"><strong>===</strong></span>