Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(supicious/noDoubleEquals): fix typo #2006

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

Kenzo-Wada
Copy link
Contributor

Summary

Test Plan

  • snapshot test

@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Mar 8, 2024
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit bb8df1e
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65ec7b39ffb76600082e80ac
😎 Deploy Preview https://deploy-preview-2006--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Mar 8, 2024

CodSpeed Performance Report

Merging #2006 will not alter performance

⚠️ No base runs were found

Falling back to comparing Kenzo-Wada:fix/typo-no-double-equals (bb8df1e) with main (0264357)

Summary

✅ 93 untouched benchmarks

Copy link
Contributor

@togami2864 togami2864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you run just gen-lint to pass tests?

@Kenzo-Wada
Copy link
Contributor Author

@togami2864

thank you for the review!
done: b145d29

Copy link
Contributor

@togami2864 togami2864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The tests are still failing, but I'll create a follow-up PR.

@togami2864 togami2864 merged commit 2eecefb into biomejs:main Mar 9, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 typo in rule description
2 participants