Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Format compat issues with Prettier #419

Closed
7 tasks done
nstepien opened this issue Sep 25, 2023 · 7 comments
Closed
7 tasks done

馃悰 Format compat issues with Prettier #419

nstepien opened this issue Sep 25, 2023 · 7 comments
Labels
A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@nstepien
Copy link
Sponsor Contributor

nstepien commented Sep 25, 2023

Environment information

playground

What happened?

Expected result

Formatting parity with prettier.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico ematipico added A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug labels Sep 26, 2023
@ematipico ematipico added the S-Help-wanted Status: you're familiar with the code base and want to help the project label Nov 10, 2023
@faultyserver
Copy link
Contributor

Taking a look at these, 4 and 6 seem to already be fixed, but weren't referenced.

I've got a fix for 5 (typeof expressions), and will start looking at 1, 2, and 3 next.

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Nov 14, 2023

Can I work on this issue?

@Conaclos
Copy link
Member

@TaKO8Ki Of course :) One particular case or the three remaining cases?

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Nov 14, 2023

@Conaclos For now, I'll try the first one!

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Nov 16, 2023

@nstepien The third issue listed here was resolved in #733. Could you change the status to completed when you have time?

@nstepien
Copy link
Sponsor Contributor Author

Done, thanks!

@nstepien
Copy link
Sponsor Contributor Author

Looks like all the compat issues I raised are now fixed, thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

No branches or pull requests

5 participants