challenge(formatter): fix self closing compatibility with Prettier #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
TaKO8Ki
commented
Nov 15, 2023
| @@ -542,6 +546,20 @@ impl<I: Iterator> JsxChildrenIterator<I> { | |||
| }) | |||
| .as_ref() | |||
| } | |||
|
|
|||
| pub fn peek_next_next(&mut self) -> Option<&I::Item> { | |||
There was a problem hiding this comment.
I have one question. Should JsxChildrenIterator be modified so that it can retrieve a specified number of elements ahead, like look_ahead? I often commit to rustc, so I mentioned rustc as an example.
There was a problem hiding this comment.
i think following the implementation of look_ahead in rustc is good. However, rewriting this util may increase the code diffs considerably, so a separate PR would be fine.
There was a problem hiding this comment.
Ok. I will implement it in a new pull request!
ematipico
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the third issue listed in #419
https://biomejs.dev/playground/?indentStyle=space"eStyle=single&trailingComma=none&code=ZQB4AHAAbwByAHQAIABmAHUAbgBjAHQAaQBvAG4AIABEAGEAdABlAFIAYQBuAGcAZQBGAG8AcgBtAGEAdAB0AGUAcgAoAHsAIABkAGEAdABlAEYAcgBvAG0ALAAgAGQAYQB0AGUAVABvACAAfQA6ACAARABhAHQAZQBSAGEAbgBnAGUAUAByAG8AcABzACkAIAB7AAoAIAAgAHIAZQB0AHUAcgBuACAAZABhAHQAZQBGAHIAbwBtACAAJgAmACAAZABhAHQAZQBUAG8AIAA%2FACAAKAAKACAAIAAgACAAPAA%2BAAoAIAAgACAAIAAgACAAPABEAGEAdABlAEYAbwByAG0AYQB0AHQAZQByACAAdgBhAGwAdQBlAD0AewBkAGEAdABlAEYAcgBvAG0AfQAgAC8APgAKACAAIAAgACAAIAAgAC0ACgAgACAAIAAgACAAIAA8AEQAYQB0AGUARgBvAHIAbQBhAHQAdABlAHIAIAB2AGEAbAB1AGUAPQB7AGQAYQB0AGUAVABvAH0AIAAvAD4ACgAgACAAIAAgADwALwA%2BAAoAIAAgACkAIAA6ACAAbgB1AGwAbAA7AAoAfQA%3D
Test Plan
All existing tests should pass. I've added a new snapshot test.