🐛 useHookAtTopLevel: unconditional hook usage flagged as conditionally called

[nstepien]

Environment information

https://biomejs.dev/playground/?indentStyle=space&quoteStyle=single&trailingComma=none&lintRules=all&code=aQBtAHAAbwByAHQAIAB7ACAAYwByAGUAYQB0AGUAQwBvAG4AdABlAHgAdAAsACAAdQBzAGUAQwBhAGwAbABiAGEAYwBrACwAIAB1AHMAZQBDAG8AbgB0AGUAeAB0ACAAfQAgAGYAcgBvAG0AIAAnAHIAZQBhAGMAdAAnADsACgAKAGMAbwBuAHMAdAAgAEMAbwBuAHQAZQB4AHQAIAA9ACAAYwByAGUAYQB0AGUAQwBvAG4AdABlAHgAdAAoAHsAfQApADsACgAKAGUAeABwAG8AcgB0ACAAZgB1AG4AYwB0AGkAbwBuACAAdQBzAGUASwBlAHkAKABrAGUAeQA6ACAAcwB0AHIAaQBuAGcAKQAgAHsACgAgACAAcgBlAHQAdQByAG4AIAB1AHMAZQBDAG8AbgB0AGUAeAB0ACgAQwBvAG4AdABlAHgAdAApAFsAawBlAHkAXQA7AAoAfQAKAAoAZQB4AHAAbwByAHQAIABmAHUAbgBjAHQAaQBvAG4AIAB1AHMAZQBTAHQAdQBmAGYAKAApACAAewAKACAAIAByAGUAdAB1AHIAbgAgAHsACgAgACAAIAAgAGEAYgBjADoAIAB1AHMAZQBDAGEAbABsAGIAYQBjAGsAKAAoACkAIAA9AD4AIABuAHUAbABsACwAIABbAF0AKQAKACAAIAB9ADsACgB9AAoACgBlAHgAcABvAHIAdAAgAGYAdQBuAGMAdABpAG8AbgAgAHUAcwBlAFMAdAB1AGYAZgAyACgAKQAgAHsACgAgACAAcgBlAHQAdQByAG4AIABbAHUAcwBlAEMAYQBsAGwAYgBhAGMAawAoACgAKQAgAD0APgAgAG4AdQBsAGwALAAgAFsAXQApAF0AOwAKAH0ACgA%3D

https://biomejs.dev/playground/?indentStyle=space&quoteStyle=single&trailingComma=none&lintRules=all&code=aQBtAHAAbwByAHQAIAB7ACAAYwByAGUAYQB0AGUAQwBvAG4AdABlAHgAdAAsACAAdQBzAGUAQwBhAGwAbABiAGEAYwBrACwAIAB1AHMAZQBDAG8AbgB0AGUAeAB0ACAAfQAgAGYAcgBvAG0AIAAnAHIAZQBhAGMAdAAnADsACgAKAGMAbwBuAHMAdAAgAEMAbwBuAHQAZQB4AHQAIAA9ACAAYwByAGUAYQB0AGUAQwBvAG4AdABlAHgAdAAoAHsAfQApADsACgAKAGUAeABwAG8AcgB0ACAAZgB1AG4AYwB0AGkAbwBuACAAdQBzAGUASwBlAHkAKABrAGUAeQA6ACAAcwB0AHIAaQBuAGcAKQAgAHsACgAgACAAcgBlAHQAdQByAG4AIAB1AHMAZQBDAG8AbgB0AGUAeAB0ACgAQwBvAG4AdABlAHgAdAApAFsAawBlAHkAXQA7AAoAfQAKAAoAZQB4AHAAbwByAHQAIABmAHUAbgBjAHQAaQBvAG4AIAB1AHMAZQBTAHQAdQBmAGYAKAApACAAewAKACAAIAByAGUAdAB1AHIAbgAgAHsACgAgACAAIAAgAGEAYgBjADoAIAB1AHMAZQBDAGEAbABsAGIAYQBjAGsAKAAoACkAIAA9AD4AIABuAHUAbABsACwAIABbAF0AKQAKACAAIAB9ADsACgB9AAoACgBlAHgAcABvAHIAdAAgAGYAdQBuAGMAdABpAG8AbgAgAHUAcwBlAFMAdAB1AGYAZgAyACgAKQAgAHsACgAgACAAcgBlAHQAdQByAG4AIABbAHUAcwBlAEMAYQBsAGwAYgBhAGMAawAoACgAKQAgAD0APgAgAG4AdQBsAGwALAAgAFsAXQApAF0AOwAKAH0ACgA%3D

What happened?

Biome flags these hooks as being conditionally called when they are not.

Expected result

No issues reported.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[msdlisper]

https://stackblitz.com/edit/node-74lxwb?file=src%2Findex.js,package.json
Links replicated with ESLint:
execute npm run lint

[atheck]

This also happens when using function components in objects:

const obj = {
  Component() {
    useState(0);

    return ...;
  }
}

[arendjr]

I have included fixes for the edge cases in the playground in #1393.

The case reported in the comment above is not yet fixed since it's a little trickier to do so. Update: The snippet from above (implementing components inside an object literal) is now supported too.

[nstepien]

@ematipico looks like there's still a bug in the playground link

[ematipico]

cc @arendjr

[arendjr]

Huh, I had not included that one in the test cases, because I didn’t see a failure before, so I figured it must’ve been fixed already. Oh well, this fix shouldn’t be too hard :)

[nstepien]

IIRC it was fixed before, there might be a regression somewhere 🤔

[nstepien]

I can still see a false-positive in the playground, is it not updated? 🤔

[arendjr]

Hm, good question. I would suspect so, because if it’s still not fixed I’ll eat my shoe 😂

[arendjr]

Playground seems fine now? 🤔

[nstepien]

Nice! Re-closing then, thanks!