Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 lint/noUnnecessaryContinue false positives when fall-through cases are present #69

Closed
1 task done
Conaclos opened this issue Aug 25, 2023 · 0 comments · Fixed by #705
Closed
1 task done

🐛 lint/noUnnecessaryContinue false positives when fall-through cases are present #69

Conaclos opened this issue Aug 25, 2023 · 0 comments · Fixed by #705
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@Conaclos
Copy link
Member

Conaclos commented Aug 25, 2023 •
edited
Loading

Environment information

main branch

What happened?

Initially reported in rome#4745.

noUnnecessaryContinue reports a false positive when a fall-through case is used.

See an example on the playground.

Expected result

This example should not be reported by the rule.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added the S-Bug-confirmed Status: report has been confirmed as a valid bug label Aug 25, 2023
@Conaclos Conaclos changed the title 🐛 noUnnecessaryContinue false positives when fall-through cases are present 🐛 lint/noUnnecessaryContinue false positives when fall-through cases are present Aug 25, 2023
@Conaclos Conaclos added L-JavaScript Language: JavaScript and super languages A-Linter Area: linter labels Aug 25, 2023
@TaKO8Ki TaKO8Ki mentioned this issue Nov 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lint): fix a false positive in lint/correctness/noUnnecessaryContinue TaKO8Ki/biome
1 participant
@Conaclos