Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): fix a false positive in lint/correctness/noUnnecessaryContinue #705

Merged

Conversation

TaKO8Ki
Copy link
Contributor

@TaKO8Ki TaKO8Ki commented Nov 12, 2023

Summary

Closes #69

If a continue is in switch block, we have to avoid report this lint error.

Test Plan

Existing tests should pass and I've updated a existing snapshot test for this change.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 12, 2023
@Conaclos Conaclos merged commit 96bbf50 into biomejs:main Nov 12, 2023
12 checks passed
@Conaclos
Copy link
Member

Thanks!

@TaKO8Ki TaKO8Ki deleted the fix-noUnnecessaryContinue-false-positive branch November 14, 2023 14:11
@Conaclos Conaclos added the A-Changelog Area: changelog label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 lint/noUnnecessaryContinue false positives when fall-through cases are present
2 participants