Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no_nodejs_modules.rs #1621

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Update no_nodejs_modules.rs #1621

merged 2 commits into from
Jan 21, 2024

Conversation

huseeiin
Copy link
Contributor

fix grammar

Summary

Test Plan

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit bad7732
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65acfb75d3bfbf00081a818c
😎 Deploy Preview https://deploy-preview-1621--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jan 21, 2024
@huseeiin
Copy link
Contributor Author

important note: this also needs to be fixed in tests and docs. this only fixes the linter's error message

@github-actions github-actions bot added the A-Website Area: website label Jan 21, 2024
Copy link

codspeed-hq bot commented Jan 21, 2024

CodSpeed Performance Report

Merging #1621 will improve performances by 9.7%

⚠️ No base runs were found

Falling back to comparing huseeiin:main (bad7732) with main (d853402)

Summary

⚡ 2 improvements
✅ 91 untouched benchmarks

Benchmarks breakdown

Benchmark main huseeiin:main Change
big5-added.json[uncached] 3.1 ms 2.9 ms +9.7%
router.ts[uncached] 13.6 ms 12.5 ms +9.18%

@ematipico ematipico merged commit b6cf3ae into biomejs:main Jan 21, 2024
19 checks passed
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 21, 2024
ematipico added a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants