Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): make playground's control flow graph scrollable #1855

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

ah-yu
Copy link
Contributor

@ah-yu ah-yu commented Feb 18, 2024

Summary

In this playground link, only a partial control flow graph can be viewed.

After fix:

Screen.Recording.2024-02-18.at.11.12.08.mov

@github-actions github-actions bot added the A-Website Area: website label Feb 18, 2024
Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit f9676b0
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65d1763ce9df54000736b07a
😎 Deploy Preview https://deploy-preview-1855--biomejs.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nhedger nhedger changed the title fix(website): fix UI issue where only a partial control flow graph can be viewed in playground fix(website): make playground's control flow graph scrollable Feb 18, 2024
@ah-yu
Copy link
Contributor Author

ah-yu commented Feb 18, 2024

@nhedger
Copy link
Member

nhedger commented Feb 18, 2024

Oh, you're right !

Copy link
Contributor

@togami2864 togami2864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great👍

@togami2864 togami2864 merged commit c53f6d1 into biomejs:main Feb 18, 2024
7 checks passed
@ah-yu ah-yu deleted the control_flow_ui branch February 18, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants