Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): result tab panel height #2057

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Mar 12, 2024

Summary

This is a follow-up fix of #1855 (comment). The result tab panel is no longer chopped off.

Test Plan

Visually confirm the result tab panel can show all of its content.

image

Code for quick testing:

try {
	undefined;
	try {
		while (true) {
			if (Date.now() > 0) {
				undefined;
				break;
			}
		}
	} finally {
		if (Date.now() > 0) undefined;
	}
	if (Date.now() > 0) undefined;
} catch {
	undefined;
}

@github-actions github-actions bot added the A-Website Area: website label Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit ceb9bca
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65f0200de91c5c0008c73fb2
😎 Deploy Preview https://deploy-preview-2057--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sec-ant Sec-ant changed the title fix(website): result panel height fix(website): result tab panel height Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 4c2ef19
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65f02267e359fb00080a7b44
😎 Deploy Preview https://deploy-preview-2057--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ematipico ematipico merged commit abf1e51 into biomejs:main Mar 12, 2024
7 checks passed
@Sec-ant Sec-ant deleted the fix-website-panel-height branch March 12, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants