Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useJsxKeyInIterable): unwrap parenthesized expression #2016

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Mar 9, 2024

Summary

Properly handle parenthesized expression function body.

Fixes #2011.

Test Plan

I added a valid test and it passed.

(<h1>{data.map(c => (<h1 key={c}></h1>))}</h1>)

Properly handle parenthesized expression function body.
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 9, 2024
Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 841d472
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65ec61bcaf33590008dcdcc2

Copy link

codspeed-hq bot commented Mar 9, 2024

CodSpeed Performance Report

Merging #2016 will not alter performance

Comparing Sec-ant:main (841d472) with main (0264357)

Summary

✅ 93 untouched benchmarks

Copy link
Contributor

@togami2864 togami2864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@togami2864 togami2864 merged commit 0763c47 into biomejs:main Mar 9, 2024
17 checks passed
@Conaclos Conaclos added the A-Changelog Area: changelog label Mar 11, 2024
@Sec-ant Sec-ant changed the title fix(useJsxKeyInIterables): unwrap parenthesized expression fix(useJsxKeyInIterable): unwrap parenthesized expression Mar 13, 2024
Sec-ant added a commit to Sec-ant/biome that referenced this pull request Mar 13, 2024
A follow-up of biomejs#2016 to handle all parenthesized expressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useJsxKeyInIterable: Not working when component starts on the next line
3 participants