Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useShorthandFunctionType): generic interface type parameters #2020

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Mar 9, 2024

Summary

Preserve type parameters of generic interfaces when applying fixes.

Fixes #2015.

Test Plan

Add an invalid case where a generic interface has a single call signature, and the fix action preserves the type parameters of the generic interface.

Preserve type parameters of generic interface when applying fix
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 9, 2024
Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 87ab7c6
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65ec75552c82820008bca489

@ematipico ematipico merged commit 71e10ed into biomejs:main Mar 9, 2024
16 checks passed
Copy link

codspeed-hq bot commented Mar 9, 2024

CodSpeed Performance Report

Merging #2020 will not alter performance

⚠️ No base runs were found

Falling back to comparing Sec-ant:fix-use-shorthand-function-type (87ab7c6) with main (0264357)

Summary

✅ 93 untouched benchmarks

@Sec-ant Sec-ant deleted the fix-use-shorthand-function-type branch March 9, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 fix of useShorthandFunctionType does not work correctly
3 participants