Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add description of exception for index usage #2023

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented Mar 9, 2024

Summary

Fixes: #1702

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 9, 2024
Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 389b70e
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65ed57be1a7e610008afff11
😎 Deploy Preview https://deploy-preview-2023--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@togami2864 togami2864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chansuke
Could you run just gen-lint to update the website?

Copy link

codspeed-hq bot commented Mar 9, 2024

CodSpeed Performance Report

Merging #2023 will not alter performance

⚠️ No base runs were found

Falling back to comparing chansuke:docs/update-for-each-docs (389b70e) with main (75eed2e)

Summary

✅ 93 untouched benchmarks

@chansuke
Copy link
Member Author

@togami2864
Ok!!

@github-actions github-actions bot added the A-Website Area: website label Mar 10, 2024
@togami2864 togami2864 merged commit 67705eb into biomejs:main Mar 10, 2024
19 checks passed
Sec-ant pushed a commit to Sec-ant/biome that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Insight needed: Why is forEach allowed if you expose the index?
4 participants