chore: review contribution document #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Conaclos
reviewed
Mar 10, 2024
ematipico
force-pushed
the
chore/review-contributing
branch
from
74590bc
to
f6da4a1
Compare
Conaclos
approved these changes
Mar 11, 2024
|
|
||
| ##### `cargo codegen analyzer` | ||
| To know the technical details of how our formatter works and how to write test, please check our [internal page](https://docs.rs/biome_js_formatter/latest/biome_js_formatter/) |
There was a problem hiding this comment.
Suggested change
| To know the technical details of how our formatter works and how to write test, please check our [internal page](https://docs.rs/biome_js_formatter/latest/biome_js_formatter/) | |
| To know the technical details of how our formatter works and how to write tests, please check our [internal page](https://docs.rs/biome_js_formatter/latest/biome_js_formatter/) |
|
oh looks like i'm late lol, will pr my suggestions |
|
I will don't worry, it's part of how we work :) thank you for the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the contribution guide
## Chekssection. Added more information around checks and broke it down with specific commands depending on what the user is doing. Added a mention tojust readyat the end of the paragraph.I removed the
rfcs/folder because we don't use it anymore. I updated thejustfileNote
I plan to do a proofread in another PR because I want to add instructions about adding new languages in Biome. We don't have any document that explains t hat.
Test Plan
Rendered file