Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused deps #2053

Merged
merged 1 commit into from
Mar 12, 2024
Merged

chore: remove unused deps #2053

merged 1 commit into from
Mar 12, 2024

Conversation

Conaclos
Copy link
Member

Summary

I used cargo-machette to detect unused dependencies.
Unfortunately we cannot use this on CI because there are false positives.

Test Plan

CI should pass.

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS labels Mar 11, 2024
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 1a3a999
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65ef8255e8dd270008e28181

Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

Copy link

codspeed-hq bot commented Mar 11, 2024

CodSpeed Performance Report

Merging #2053 will improve performances by 8.16%

Comparing conaclos/machette (1a3a999) with main (e2f67c2)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/machette Change
router.ts[cached] 11.6 ms 10.8 ms +8.16%

@Conaclos Conaclos merged commit 929faeb into main Mar 12, 2024
21 checks passed
@Conaclos Conaclos deleted the conaclos/machette branch March 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-Formatter Area: formatter A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants