refactor(project): new crate biome_configuration #2269
Conversation
github-actions
bot
added
A-CLI
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
unvalley
changed the title
CodSpeed Performance ReportMerging #2269 will improve performances by 6.05%Falling back to comparing Summary
Benchmarks breakdown
|
| @@ -111,58 +107,6 @@ impl FromStr for FormatterConfiguration { | |||
| } | |||
| } | |||
|
|
|||
| pub fn to_format_settings( | |||
There was a problem hiding this comment.
These conversion logics (to_*_settings) are moved in crates/biome_service/src/settings.rs
There was a problem hiding this comment.
The code that depends on the implementation within the biome_service crate has not been moved out of this crate
| } | ||
|
|
||
| impl FusedIterator for ConfigurationDiagnosticsIter<'_> {} | ||
| pub trait PartialConfigurationExt { |
There was a problem hiding this comment.
This new trait to implement logic that depends on the biome_serivce's implementation.
Co-authored-by: shoaibkh4n <shoaibkh4n@users.noreply.github.com> Co-authored-by: ematipico <my.burning@gmail.com>
unvalley
force-pushed
the
biome-configuration
branch
from
8b8b4d5
to
c46270e
Compare
There was a problem hiding this comment.
@ematipico @Conaclos (I saw you recently updated it)
I'm unsure about how these snapshot files /biome_configuration/src/snapshots/*.snap (previously at biome_service/src/configuration/snapshots/*.snap) are executed, because I couldn't find the original snapshot files (here it should be some json files). please let me know if you know anything about it.
There was a problem hiding this comment.
I just updated this snapshot by running just test. I have no more info...
Summary
This PR moves
biome_service's config-related code tobiome_configuration.But some code that depends
biomie_service(e.g.WorkspaceError) is still there.Closes #1738 #1742
Test Plan
All tests should pass.