refactor(biome_deserialize): replace is_type() with visitable_type()
#2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for biomejs failed. Why did it fail? →
|
Conaclos
force-pushed
the
conaclos/biome_deserialize/visitable-type
branch
from
a64a6e7
to
a08f398
Compare
Conaclos
changed the title
is_type() with visitable_type()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a minor refactoring that replaces
DeserializableValue::is_typewithDeserializableValue::visitableType. This looks more idiomatic to return the type instead of testing it.Test Plan
CI should pass.