perf(npm): use linked binary package for startup boost #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script should improve startup performance of CLI by ~2-3 times and very huge impact for `lint-staged`, `pre-commit` and `pre-push` commits
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Is this PR ready for review? |
|
@Conaclos after this PR, bunx or npx may not work so i think it’s good to close PR. If for you important startup time, you can use biome-rs-npm repository as dependency from my repositories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes/PR should improve startup performance of CLI by up to 5 times and very huge impact for
lint-staged,pre-commitandpre-pushcommitsRelated discussion: #2315
Test Plan
Locally i have not able to fully run tests and CI neither with
actand manually due of more steps of which i can't run my machine