Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_js_analyze): noConstantMathMinMaxClamp #2404

Merged
merged 7 commits into from
Apr 14, 2024

Conversation

mgomulak
Copy link
Contributor

@mgomulak mgomulak commented Apr 10, 2024

Summary

This PR closes #2304.

It implements noConstantMathMinMaxClamp which disallows the use of Math.min and Math.max to clamp a value which results in a constant value.

Test Plan

Added test cases

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 66e6b35
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/6618f1bbc18de800081f9d1a
😎 Deploy Preview https://deploy-preview-2404--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Apr 11, 2024

CodSpeed Performance Report

Merging #2404 will not alter performance

Comparing mgomulak:noConstantMathMinMax (66e6b35) with main (a5242a2)

Summary

✅ 93 untouched benchmarks

@mgomulak mgomulak changed the title feat(biome_js_analyze): noConstantMathMinMax feat(biome_js_analyze): noConstantMathMinMaxClamp Apr 11, 2024
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution. This will be part of the tomorrow's release :)

@Conaclos Conaclos merged commit 75af801 into biomejs:main Apr 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement lint/noConstantMinMax - clippy/min_max
3 participants