-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): support passing file path to --config-path
and BIOME_CONFIG_PATH
#2419
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #2419 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, a lot of significant improvements! Thank you!
Considering that you updated the docs too, what do you think we merge this PR to the release/1.7.0
branch, so the new docs will be published at the release date?
crates/biome_cli/tests/snapshots/main_cases_config_path/set_config_path_to_directory.snap
Outdated
Show resolved
Hide resolved
That would be great. But how does that work? Do I need to do something? |
Just changing the base branch of the PR. |
d8775a5
to
5b22963
Compare
19002e7
to
ee6c69f
Compare
It seems there are a bunch of conflicts. I suggest reverting the change and point that to |
I can resolve the conflicts or revert the base to main. Or @Conaclos can do that if he wants. Each is ok by me. But currently I only have my phone around and have to go to bed now. Please leave a comment to let me know if I should do something and I can address them my time tomorrow. |
@Sec-ant Feel free to address them. |
5b22963
to
fae28a3
Compare
This branch is rebased on the latest release/v1.7.0 |
Summary
Support passing file path to
--config-path
andBIOME_CONFIG_PATH
. Closes 📎 Accept files for--config-path
andBIOME_CONFIG_PATH
#2265.Fix external configuration resolution base path. Closes 🐛 Providing
--config-path
changes cwd for"extends"
module resolving #2231.Test Plan
Added a test case for the 1st feat, and tested manually in VS Code for the 2nd fix.