feat(rule/solidjs): add no-react-specific-props

[marvin-j97]

Summary

SolidJS has a couple of rules that may be useful, especially when transitioning from React, see #3 (comment).

(in SolidJS Discord)

... — 12.02.2024 10:49
Hi, I'm one of the core contributors of Biome.

We're interested in implementing solid linting rules, unfortunately we lack the knowledge and some rules aren't well documented. Is there interest in helping us?

---

Me — 12.02.2024 18:25
- solid/no-destructure
- solid/prefer-show
- solid/prefer-for
- solid/no-react-deps
- solid/no-react-specific-props
- solid/components-return-once

those should be the most useful rules, especially for React users, i think

Test Plan

invalid.jsx only works for 2 out of 3 test cases right now. I'm essentially using the same implementation as no-duplicate-jsx-props, but I don't know why className with a brace expression is not getting picked up yet... I'm not really familiar with Biome's codebase yet, so this PR is an attempt to get into it, this is probably an easy fix. Also I'm not sure if the rule should be part of nursery or if SolidJS rules may need a new group altogether...

• Check for className
• Check for htmlFor
• Auto-fix action

[netlify]

✅ Deploy Preview for biomejs ready!

Name	Link
🔨 Latest commit	99247a2
🔍 Latest deploy log	https://app.netlify.com/sites/biomejs/deploys/661e74ca23bc590008cbeab6
😎 Deploy Preview	https://deploy-preview-2427--biomejs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🔴 down 5 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ematipico]

Thank you @marvin-j97 for taking some initiative!

I will take a look at the rules in the coming days.

As for now, all rules must pass an incubation phase, hence the nursery group. During this incubation phase, we can implement the rule however we want.

Then, we will decide the final group :)

[codspeed-hq]

CodSpeed Performance Report

Merging #2427 will improve performances by 6.06%

_{Comparing marvin-j97:rules/solidjs/noReactSpecificProps (fb0a974) with main (4164331)}

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	marvin-j97:rules/solidjs/noReactSpecificProps	Change
⚡	eucjp.json[cached]	4.3 ms	4.1 ms	+6.06%

[marvin-j97]

@ematipico Snapshot tests are working now, the JSX fixtures were not delimited by semicolon...

[ematipico]

Awesome @marvin-j97! Could you open an umbrella issue to track all the rules we need to implement, with relative documentation, please?

That would help to have a central place where we can coordinate the work and maybe seek more volunteers.

[ematipico]

The rule now is easier to understand and to handle. I left few suggestions around coding and docs. We can merge the PR after we addressed them

[ematipico]

Still a couple of changes, and we're good to go

[eMerzh]

I think the website was moved away before the PR was merged or smth .. leading to a single file empty website folder 🤔

[ematipico]

You're an eagle!! Good eye