Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(benchmark): update eslint to v9 #2431

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

chansuke
Copy link
Contributor

@chansuke chansuke commented Apr 13, 2024

Summary

FIxes #2326

Test Plan

Operating System: Ubuntu 23.04                    
          Kernel: Linux 6.2.0-39-generic
    Architecture: x86-64
 Hardware Vendor: Alienware
  Hardware Model: Alienware m17 R5 AMD
Firmware Version: 1.1.2

docker build --rm -f Dockerfile.benchmark . --progress plain

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit a0220ac
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/661a7080061220000821662c
😎 Deploy Preview https://deploy-preview-2431--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -1,4 +1,4 @@
FROM rust:1.69.0@sha256:c2dcc19371a976065950915307b03a9c5514e5143bdd833635d5501a0642992e
FROM rust:1.77.2@sha256:da23629cc6826f0c395c8697994cdce0b5ac6850a695c448a101c3cc9cd6a59b
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:

#8 69.41 error: failed to compile `hyperfine v1.18.0`, intermediate artifacts can be found at `/tmp/cargo-installVcS5Gb`
#8 69.41 
#8 69.41 Caused by:
#8 69.41   package `anstyle-parse v0.2.3` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.69.0
#8 69.41   Try re-running cargo install with `--locked`
#8 ERROR: process "/bin/sh -c cargo install hyperfine" did not complete successfully: exit code: 101

Copy link
Member

@SuperchupuDev SuperchupuDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@SuperchupuDev SuperchupuDev changed the title Update eslint to v9 chore(benchmark): update eslint to v9 Apr 13, 2024
@SuperchupuDev SuperchupuDev merged commit 9ace3c5 into biomejs:main Apr 13, 2024
5 checks passed
@chansuke
Copy link
Contributor Author

@SuperchupuDev
Thank you for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Update ESLint benchmark to v9
3 participants