-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(benchmark): update eslint to v9 #2431
Merged
SuperchupuDev
merged 3 commits into
biomejs:main
from
chansuke:chore/update-eslint-to-v9
Apr 13, 2024
Merged
chore(benchmark): update eslint to v9 #2431
SuperchupuDev
merged 3 commits into
biomejs:main
from
chansuke:chore/update-eslint-to-v9
Apr 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chansuke
commented
Apr 13, 2024
@@ -1,4 +1,4 @@ | |||
FROM rust:1.69.0@sha256:c2dcc19371a976065950915307b03a9c5514e5143bdd833635d5501a0642992e | |||
FROM rust:1.77.2@sha256:da23629cc6826f0c395c8697994cdce0b5ac6850a695c448a101c3cc9cd6a59b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes:
#8 69.41 error: failed to compile `hyperfine v1.18.0`, intermediate artifacts can be found at `/tmp/cargo-installVcS5Gb`
#8 69.41
#8 69.41 Caused by:
#8 69.41 package `anstyle-parse v0.2.3` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.69.0
#8 69.41 Try re-running cargo install with `--locked`
#8 ERROR: process "/bin/sh -c cargo install hyperfine" did not complete successfully: exit code: 101
SuperchupuDev
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
SuperchupuDev
changed the title
Update eslint to v9
chore(benchmark): update eslint to v9
Apr 13, 2024
Conaclos
approved these changes
Apr 13, 2024
@SuperchupuDev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FIxes #2326
Test Plan