Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(js_syntax): remove TsNameWithTypeArguments #2510

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Apr 18, 2024

Summary

Close #2338

TsNameWithTypeArguments and TsReferenceType have basically the same shape.
This PR removes TsNameWithTypeArguments and use TsReferenceType instead.

Test Plan

I updated the parser snapshots.

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Apr 18, 2024
@Conaclos Conaclos force-pushed the conaclos/remove-TsNameWithTypeArguments branch from fc566a3 to 1da79e6 Compare April 18, 2024 14:29
@github-actions github-actions bot removed the A-Website Area: website label Apr 18, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

Copy link

codspeed-hq bot commented Apr 18, 2024

CodSpeed Performance Report

Merging #2510 will degrade performances by 7.78%

Comparing conaclos/remove-TsNameWithTypeArguments (1da79e6) with main (4164331)

Summary

❌ 2 regressions
✅ 91 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/remove-TsNameWithTypeArguments Change
db.json[cached] 67.4 ms 73.1 ms -7.78%
eucjp.json[uncached] 4.8 ms 5.2 ms -7.22%

@Conaclos Conaclos merged commit 2c4d6e7 into main Apr 18, 2024
16 of 17 checks passed
@Conaclos Conaclos deleted the conaclos/remove-TsNameWithTypeArguments branch April 18, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Investigate AST nodes TsNameWithTypeArguments vs TsReferenceType
3 participants