feat(linter): add useConsistentNewBuiltin #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
minht11
commented
Apr 20, 2024
crates/biome_js_analyze/src/lint/nursery/use_new_for_builtins.rs
Outdated
Show resolved
Hide resolved
ematipico
reviewed
Apr 21, 2024
crates/biome_js_analyze/src/lint/nursery/use_new_for_builtins.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_new_for_builtins.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_new_for_builtins.rs
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #2540 will not alter performanceComparing Summary
|
minht11
changed the title
Implement initial useForBuiltins Update snapshots Changes
minht11
force-pushed
the
feat/useNewForBuiltins
branch
from
4be6c6e
to
b4cb496
Compare
Conaclos
reviewed
Apr 22, 2024
crates/biome_js_analyze/src/lint/nursery/use_consistent_new_builtin.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_new_builtin.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_new_builtin.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_new_builtin.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_new_builtin.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_new_builtin.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Apr 23, 2024
ematipico
approved these changes
Apr 24, 2024
|
Can you fix the conflict @minht11 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2539
Implements unicorn/new-for-builtins
Example:
Date()->new Date()This is my first time writing Rust, so I wasn't quite sure which things to use where.
Test Plan
added tests and snapshots