Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): Implement useGenericFontNames #2573

Merged
merged 9 commits into from
Apr 26, 2024
Merged

feat(linter): Implement useGenericFontNames #2573

merged 9 commits into from
Apr 26, 2024

Conversation

togami2864
Copy link
Contributor

Summary

close #2572

Test Plan

added tests and snapshots

@togami2864 togami2864 self-assigned this Apr 23, 2024
@github-actions github-actions bot added A-Project Area: project L-CSS Language: CSS A-Diagnostic Area: diagnostocis labels Apr 23, 2024
@togami2864 togami2864 force-pushed the feat/no-missing-generic-family-keyword branch from 1aa1b45 to 67d870b Compare April 23, 2024 15:29
@Conaclos
Copy link
Member

Conaclos commented Apr 23, 2024 •
edited

Just wondering: why not rename to useGenericFontNames?

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 23, 2024 •
edited

CodSpeed Performance Report

Merging #2573 will not alter performance

Comparing togami2864:feat/no-missing-generic-family-keyword (792b747) with main (e96781a)

Summary

✅ 90 untouched benchmarks

@ematipico
Copy link
Member

I like very much @Conaclos suggestion! The rule doesn't forbid a concept, but it wants to promote one. (reminder of the explanation of the rule names here)

@togami2864
Copy link
Contributor Author

togami2864 commented Apr 25, 2024 •
edited

That makes sense to me :)

@togami2864 togami2864 force-pushed the feat/no-missing-generic-family-keyword branch from 67d870b to 7eee138 Compare April 25, 2024 11:42
@togami2864 togami2864 changed the title feat(biome_css_analyzer): Implement noMissingGenericFamilyKeyword feat(biome_css_analyzer): Implement useGenericFontNames Apr 25, 2024
@ematipico ematipico changed the title feat(biome_css_analyzer): Implement useGenericFontNames feat(linter): Implement useGenericFontNames Apr 25, 2024
@togami2864 togami2864 force-pushed the feat/no-missing-generic-family-keyword branch from 7eee138 to 792b747 Compare April 26, 2024 13:28
@togami2864 togami2864 merged commit b3ed181 into biomejs:main Apr 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

@togami2864 togami2864

Labels
A-Diagnostic Area: diagnostocis A-Project Area: project L-CSS Language: CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Implement font-family-no-missing-generic-family-keyword
3 participants
@togami2864 @Conaclos @ematipico