refactor(codemod/biome_js_analyze): remove manual construction of JsRuleAction
#2874
Conversation
github-actions
bot
added
A-Linter
CodSpeed Performance ReportMerging #2874 will not alter performanceComparing Summary
|
|
CI is failing due to clippy error |
dyc3
force-pushed
the
05-12-refactor_codemod_biome_js_analyze_remove_manual_construction_of_jsruleaction_
branch
from
77680aa
to
5dbf3e0
Compare
dyc3
force-pushed
the
05-12-refactor_codemod_biome_js_analyze_remove_manual_construction_of_jsruleaction_
branch
from
5dbf3e0
to
243c60c
Compare
| @@ -26,7 +26,7 @@ declare_rule! { | |||
| /// | |||
| /// ```ts,expect_diagnostic | |||
| /// class SomeClass { | |||
| /// message: Array<Array<any>>; | |||
There was a problem hiding this comment.
This is probably a result of find and replace that breaks the tests in the website repo:
https://github.com/biomejs/website/actions/runs/9109965581/job/25043948850#step:8:378
| @@ -43,7 +43,7 @@ declare_rule! { | |||
| /// | |||
| /// ```ts | |||
| /// class SomeClass<T extends any> { | |||
| /// message: Array<Array<unknown>>; | |||
There was a problem hiding this comment.
This is probably a result of find and replace that breaks the tests in the website repo:
https://github.com/biomejs/website/actions/runs/9109965581/job/25043948850#step:8:378
There was a problem hiding this comment.
You forgot to fix this one in 7bcc112 @ematipico
I fixed it in #2883.
|
cc @dyc3 |
|
Fixed in 7bcc112 |
|
Whoops, my bad. It was definitely because I find/replaced that text. Do you have a better way of doing these kinds of large codemods? I'm not aware of any tools that do that |
dyc3
deleted the
05-12-refactor_codemod_biome_js_analyze_remove_manual_construction_of_jsruleaction_
branch
I've never used it in repos like biome but you can try gritql which is also what biome plans to use to support plugins. Anyway these kind of errors are supposed to be catched by tests, it's just a limitation of our current setup (main repo + website repo codegen) which makes these kind of errors more difficult to avoid. |
Summary
This is a follow up to #2820.
Related to: #2799
Test Plan
It compiles, tests pass.