Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): rename noCssEmptyBlock -> noEmptyBlock #2945

Merged
merged 4 commits into from
May 22, 2024

Conversation

togami2864
Copy link
Contributor

Summary

Rename noCssEmptyBlock to noEmptyBlock and remove option.
ref #2511 (comment)

Test Plan

CI should pass

@togami2864 togami2864 self-assigned this May 22, 2024
@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project L-CSS Language: CSS A-Diagnostic Area: diagnostocis labels May 22, 2024
@@ -115,7 +73,7 @@ impl Rule for NoCssEmptyBlock {
rule_category!(),
span,
markup! {
"Empty blocks aren't allowed."
"Empty block isn't allowed."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Empty block isn't allowed."
"An empty block isn't allowed."

Copy link

codspeed-hq bot commented May 22, 2024

CodSpeed Performance Report

Merging #2945 will not alter performance

Comparing togami2864:chore/rename-no-empty (d148753) with main (a51fa60)

Summary

✅ 92 untouched benchmarks

@togami2864 togami2864 merged commit e64ab12 into biomejs:main May 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Project Area: project L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants