Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_js_analyzer): useTrimStartEnd #3123

Merged
merged 41 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
58517dc
feat(biome_js_analyzer): `useTrimStartEnd`
chansuke Jun 8, 2024
00261f2
fix: gen-lint
chansuke Jun 10, 2024
ec1871a
refactor: improve declaration of the rule
chansuke Jun 13, 2024
7b60bba
chore: run gen-lint
chansuke Jun 13, 2024
10077ff
fix: remove illegal syntax test cases
chansuke Jun 13, 2024
31be2ef
docs: update CHANGELOG
chansuke Jun 13, 2024
0adcc39
chore: update testcase
chansuke Jun 14, 2024
ec91114
fix: show replaced member name
chansuke Jun 14, 2024
baf0b93
chore: add `String.`
chansuke Jun 14, 2024
7d690a8
fix: add logic for parameters
chansuke Jun 14, 2024
5325cd3
chore: run gen-lint
chansuke Jun 14, 2024
c4c2edd
fix: add logic for computed memeber expression
chansuke Jun 15, 2024
c1d5178
refactor: change type of argument
chansuke Jun 15, 2024
7d779a3
feat: implement action for computed member expression case
chansuke Jun 23, 2024
05b2a4f
feat(biome_js_analyzer): `useTrimStartEnd`
chansuke Jun 8, 2024
3068111
feat: implement the action logic for computed expression
chansuke Jun 23, 2024
25e69a0
chore: run gen-lint
chansuke Jun 23, 2024
0a470c5
chore: fix wording
chansuke Jun 23, 2024
4bc9713
chore: update snapshot
chansuke Jun 23, 2024
21a0728
chore: add comment
chansuke Jun 23, 2024
2c0fdf6
chore: add more description
chansuke Jun 23, 2024
3c49879
chore: update changelog entry
chansuke Jun 29, 2024
a168e74
chore: run gen-lint
chansuke Jun 29, 2024
8509590
refactor: update suggenst name handling
chansuke Jun 29, 2024
f4f3017
chore: run gen-lint
chansuke Jun 29, 2024
284f366
fix: remove redundant allocation
chansuke Jul 4, 2024
8a684ba
fix: handle error
chansuke Jul 4, 2024
3c2285f
refactor: use `can_cast`
chansuke Jul 6, 2024
19c7c1e
refactor: use variable for `.as_js_computed_member_expression()`
chansuke Jul 8, 2024
63b8e89
refactor: use better naming
chansuke Jul 8, 2024
fad4c97
chore: run gen-lint
chansuke Jul 9, 2024
e421346
chore: gen-lint
chansuke Jul 10, 2024
cb93287
Merge branch 'main' into feat/use-trim-start-end
chansuke Jul 10, 2024
67c00f5
chore: update rules.rs
chansuke Jul 12, 2024
37f32b0
reafactor: update quote handling
chansuke Jul 14, 2024
b3b0d2d
fix: remove print debug
chansuke Jul 17, 2024
f1f8db2
fix: remove unused variable
chansuke Jul 17, 2024
db74640
fix: avoid using `unreachable`
chansuke Jul 17, 2024
8f75411
Merge branch 'main' into feat/use-trim-start-end
chansuke Jul 17, 2024
99a6a88
chore: update rules.rs
chansuke Jul 17, 2024
f071090
Merge branch 'main' into feat/use-trim-start-end
chansuke Jul 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
Contributed by @Conaclos

- Add [nursery/noIrregularWhitespace](https://biomejs.dev/linter/rules/no-irregular-whitespace). Contributed by @michellocana
- Add [nursery/useTrimStartEnd](https://biomejs.dev/linter/rules/use-trim-start-end/). Contributed by @chansuke

#### Enhancements

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 21 additions & 2 deletions crates/biome_configuration/src/linter/rules.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/biome_diagnostics_categories/src/categories.rs
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ define_categories! {
"lint/nursery/useThrowNewError": "https://biomejs.dev/linter/rules/use-throw-new-error",
"lint/nursery/useThrowOnlyError": "https://biomejs.dev/linter/rules/use-throw-only-error",
"lint/nursery/useTopLevelRegex": "https://biomejs.dev/linter/rules/use-top-level-regex",
"lint/nursery/useTrimStartEnd": "https://biomejs.dev/linter/rules/use-trim-start-end",
"lint/nursery/useValidAutocomplete": "https://biomejs.dev/linter/rules/use-valid-autocomplete",
"lint/performance/noAccumulatingSpread": "https://biomejs.dev/linter/rules/no-accumulating-spread",
"lint/performance/noBarrelFile": "https://biomejs.dev/linter/rules/no-barrel-file",
Expand Down
2 changes: 2 additions & 0 deletions crates/biome_js_analyze/src/lint/nursery.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading