-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(biome_js_analyzer): useTrimStartEnd
#3123
Conversation
CodSpeed Performance ReportMerging #3123 will degrade performances by 8.13%Comparing Summary
Benchmarks breakdown
|
crates/biome_js_analyze/tests/specs/nursery/useTrimStartEnd/valid.js
Outdated
Show resolved
Hide resolved
71b7992
to
59739a4
Compare
75b1aaf
to
d0b13d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rerun the codegen task to pass the check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments on the test cases. Also, could you please add a changelog entry for this rule and noSubstr
, the one you worked on earlier?
crates/biome_js_analyze/tests/specs/nursery/useTrimStartEnd/valid.js
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/tests/specs/nursery/useTrimStartEnd/valid.js
Outdated
Show resolved
Hide resolved
c007dbe
to
8e39fc3
Compare
ad3a0e4
to
fad4c97
Compare
Summary
Part of #2817
Test Plan
just test-lintrule useTrimStartEnd