Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

challenge(formatter): predictable order of type parameter modifiers #719

Merged
merged 1 commit into from Nov 14, 2023

Conversation

Conaclos
Copy link
Member

Summary

Fix #717

This PR adds a predictable order for Type parameter modifiers (const, in, out).

Prettier also format a bogus node (const is not allowed for type parameter of interfaces):

interface L<in const T> {}

Thus, Biome doesn't turn in const into const in.

Test Plan

Updated prettier diff.

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Nov 14, 2023
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13454 13454 0
Failed 4190 4190 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

@Conaclos Conaclos changed the title challenge(prettier-compat): predictable order of type parameter modifiers challenge(formatter): predictable order of type parameter modifiers Nov 14, 2023
@Conaclos Conaclos requested a review from a team November 14, 2023 15:07
@ematipico ematipico requested a review from a team November 14, 2023 15:19
@Conaclos Conaclos merged commit fc877aa into main Nov 14, 2023
16 checks passed
@Conaclos Conaclos deleted the conaclos/js_formatter/type-param-modifier-precedence branch November 14, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 [Prettier Compat Challenge] typescript/typeparams/const.ts
2 participants