challenge(formatter): respect prettier Range
options
#774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some test cases in
prettier-snap
files did not respect Prettier's Range options (formatted the entire code instead of the partial code in the range). This is the fix to respect the Range options.I updated test cases with Prettier repo as of 093745f0ec429d3db47c1edd823357e0ef24e226 commit hash
Test Plan
prepare_tests.js
changes are valid and updated test cases are valid.cargo test -p biome_js_formatter --test prettier_tests
Note
When running
node prepare_tests.js <<Prettier Repo Path>>
, the following files are updated, but looks like these are not compatible with the current Biome, so ignored these changes.