challenge(formatter): fix typescript/union/inlining #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
Conaclos
reviewed
Nov 19, 2023
Conaclos
force-pushed
the
challenge/typescript_union_inlining
branch
from
4859812
to
a7b978d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checks for comments in
biome_js_formatter/typescript/utils::should_hug_typeand prevents hugging in that case. Not sure why thereport.mdis updating withjs/*test cases as my work was only in thetypescriptpart of the formatter.Test Plan
My implementation brought 100% Prettier similarity on the
typescript/union/inliningtest case. I also fixed the reformat issue ontypescript/union/single-type.