challenge(formatter): Handle special first-argument expansions in call arguments #777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
As a byproduct of this, the following are also fixed:
The implementation of this feels a little hacky, but that's exactly how Prettier describes their implementation too lol.
As part of this, I ended up making the
SimpleArgument
enum fully public so that it can be used outside ofmethod_chain
. I think that makes sense sincecall_arguments
ends up doing a lot of the same kinds of checks, but if that's not reasonable I can figure out another way to do this instead.Test Plan
Relevant prettier diff snapshots now match and have been deleted.