challenge(formatter): arrows comment #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
|
Hi! Thanks for your contribution :) You have to lint and to format your code using |
ematipico
reviewed
Nov 19, 2023
| @@ -157,6 +153,29 @@ fn handle_typecast_comment(comment: DecoratedComment<JsLanguage>) -> CommentPlac | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| fn handle_after_arrow_fat_arrow_comment( | |||
There was a problem hiding this comment.
Could you add a documentation comment that explains what this function does? How it moves the comments and where
There was a problem hiding this comment.
Thanks for the review, I've put the comments in the code, do you think that's OK？
unvalley
reviewed
Nov 20, 2023
crates/biome_js_formatter/src/js/expressions/arrow_function_expression.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
js/arrows/comment.js
Test Plan
Relevant prettier diff snapshots now match and have been deleted.