challenge(formatter): Implement bracketSameLine
option to match Prettier
#799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review: I'd recommend just checking the first commit and the third one. The second is the one with all the snapshot file updates, and the fourth is just website codegen.
Summary
This should be the last big option that Prettier supports that Biome doesn't (other than the Pragma options). All that this option does is force the closing bracket of a multiline opening JSX tag (or HTML/Vue, once those are supported) to hug onto the end of the last attribute line rather than get placed on its own line afterward.
For example:
And with the option disabled, which is the new behavior:
Test Plan
New snapshot test in the CLI and in
biome_js_formatter
checks that this option is being applied correctly.All snapshots have also been updated with the additional configuration readout.