challenge(formatter): sloppy mode tests #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
victor-teles
force-pushed
the
fix/sloppy-mode
branch
3 times, most recently
from
e442625
to
db4d812
Compare
Conaclos
approved these changes
Nov 20, 2023
victor-teles
force-pushed
the
fix/sloppy-mode
branch
from
37ebadf
to
74b0da3
Compare
victor-teles
force-pushed
the
fix/sloppy-mode
branch
from
74b0da3
to
a5e03be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes
For some cases we need to run the test using ModuleKind::Script.
I've added a allowlist to allow tests from prettier that need to run in sloppy mode.
Test Plan
Updated snapshots