Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

challenge(formatter): handle let variable name in non-strict mode #814

Merged
merged 1 commit into from Nov 21, 2023

Conversation

Conaclos
Copy link
Member

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Nov 21, 2023
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13454 13454 0
Failed 4190 4190 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

@Conaclos
Copy link
Member Author

!bench_formatter

Copy link
Contributor

Formatter Benchmark Results

group                                    main                                   pr
-----                                    ----                                   --
formatter/big5-added.json                1.00    366.1±6.31µs    46.2 MB/sec    1.00    366.5±1.48µs    46.1 MB/sec
formatter/canada.json                    1.02    169.2±4.21ms    12.7 MB/sec    1.00    166.4±3.82ms    12.9 MB/sec
formatter/checker.ts                     1.00    271.0±2.90ms     9.6 MB/sec    1.03    279.5±5.98ms     9.3 MB/sec
formatter/compiler.js                    1.00    152.9±2.11ms     6.9 MB/sec    1.02    156.7±3.52ms     6.7 MB/sec
formatter/d3.min.js                      1.00    117.6±2.02ms     2.2 MB/sec    1.02    120.5±2.43ms     2.2 MB/sec
formatter/db.json                        1.00     10.6±0.07ms    17.2 MB/sec    1.05     11.2±0.14ms    16.4 MB/sec
formatter/dojo.js                        1.00      8.5±0.04ms     8.1 MB/sec    1.03      8.7±0.06ms     7.9 MB/sec
formatter/eucjp.json                     1.00    629.5±4.63µs    62.2 MB/sec    1.01   635.5±20.44µs    61.6 MB/sec
formatter/ios.d.ts                       1.00    173.9±2.17ms    10.7 MB/sec    1.00    174.7±2.80ms    10.7 MB/sec
formatter/jquery.min.js                  1.00     34.1±0.17ms     2.4 MB/sec    1.03     35.0±0.16ms     2.4 MB/sec
formatter/math.js                        1.00    238.1±4.84ms     2.7 MB/sec    1.03    245.0±3.86ms     2.6 MB/sec
formatter/package-lock.json              1.00      4.6±0.06ms    30.2 MB/sec    1.00      4.6±0.02ms    30.2 MB/sec
formatter/parser.ts                      1.00      5.9±0.02ms     8.3 MB/sec    1.03      6.0±0.04ms     8.1 MB/sec
formatter/pixi.min.js                    1.00    129.4±1.48ms     3.4 MB/sec    1.02    131.7±1.48ms     3.3 MB/sec
formatter/react-dom.production.min.js    1.00     38.6±0.32ms     3.0 MB/sec    1.02     39.6±0.35ms     2.9 MB/sec
formatter/react.production.min.js        1.00  1977.0±14.57µs     3.1 MB/sec    1.02      2.0±0.03ms     3.0 MB/sec
formatter/router.ts                      1.00      2.1±0.02ms    11.4 MB/sec    1.02      2.1±0.03ms    11.1 MB/sec
formatter/tex-chtml-full.js              1.00    304.0±4.59ms     3.0 MB/sec    1.03    311.7±5.29ms     2.9 MB/sec
formatter/three.min.js                   1.00    152.3±3.08ms     3.9 MB/sec    1.03    157.0±5.09ms     3.7 MB/sec
formatter/typescript.js                  1.00   1033.4±9.87ms     9.2 MB/sec    1.03  1065.6±11.19ms     8.9 MB/sec
formatter/vue.global.prod.js             1.00     51.6±0.33ms     2.3 MB/sec    1.03     52.9±0.55ms     2.3 MB/sec

@Conaclos Conaclos merged commit 478074f into main Nov 21, 2023
16 checks passed
@Conaclos Conaclos deleted the conaclos/challenge/handle-let-var-name branch November 21, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant