Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grizzly-ls: ModuleNotFound gevent #299

Closed
mgor opened this issue Dec 13, 2023 · 1 comment
Closed

grizzly-ls: ModuleNotFound gevent #299

mgor opened this issue Dec 13, 2023 · 1 comment
Labels
bug Something isn't working grizzly-ls

Comments

@mgor
Copy link
Collaborator

mgor commented Dec 13, 2023

Describe the bug
grizzly-ls tries to noop gevent.monkey.patch_all, but gevent is not an dependency of grizzly-ls (only in grizzly context).

To Reproduce
Install grizzly-loadtester-ls in a project that does not have gevent as an requirement.

Expected behavior
It should work in projects that does not have gevent as an requirement.
@mgor mgor added bug Something isn't working grizzly-ls labels Dec 13, 2023
mgor added a commit to mgor/grizzly-lsp that referenced this issue Dec 13, 2023
@mgor
gevent is not a requirement
2fd9de4 
optional monkey patching, to handle it being installed in projects that does not have `gevent` as an requirement.

fixes Biometria-se/grizzly#299.
@mgor
Copy link
Collaborator Author

mgor commented Dec 21, 2023

fixed in Biometria-se/grizzly-lsp#51.

@mgor mgor closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grizzly-ls
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgor