-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick scope update before use #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updating the readme This changed the content of the readme, moving the format to adoc (from md), and updating the info. Also includes a folder name change (made a typo). Added an MIT license for the content as well. * Update MobileUseCaseV2.md URL changes and one misspelling. No other changes. I think this should probably be split into separate files instead of one large one. * Delete PP_Config-OS.adoc * Update README.adoc * Update Docs_README.adoc
Proposed changes for the TD to add the sample quality research paper and an explicit reference for the validator to point to this as a reference.
Date updates
The language for the PP-Module has used "enrol" but the definitions list has "Failure-to-Enroll". Given the standard usage of one "l", this should be edited. This can wait until the next update and does not need to be made into an interpretation, but should be fixed in the next major release.
This changed the content of the readme, moving the format to adoc (from md), and updating the info. Also includes a folder name change (made a typo). Added an MIT license for the content as well.
This is to close #301
This is to close #303. Both the assumptions and the objectives are removed.
updated based on @gfiumara comment
Found "enroll"
scope specification
completing the removal of assumptions as specified by @n-kai and the NIAP comments (missed the table previously)
This reverts commit a03b6bd.
This reverts commit 2c09b39.
This reverts commit 7f2b79c.
This reverts commit 9c6a884.
This reverts commit 1da95b9.
This is for @n-kai to show these commits directly. This is based on the assumptions branch, but specifically moves his commits into a new branch (there is a little bit of a mess in the assumptions branch as I pulled them over). This is to close #302 at this time. There are changes here for #300 as well.
removing assumptions
Consistency and Rationale edit
changed "protect" to "protects" in phrases where "shall" had been removed.
Per discussion: #315 (comment)
Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov>
Update to address comments in #354
Update to modify and add sample quality testing
…_MBV_EXT.3.1 Nkai update appnote for fia mbv ext.3.1
I found this while looking at the ECD for something else. Just an inconsistent title
inconsistent ECD
Summary of changes: - PP_MD -> PP_MDF (v3.2 made the change from MD to MDF) - revisions v1.0 (or 0.99) -> v1.1 for all docs - PPC-MDF -> CFG-MDF-BIO in references
Changes for publication
* verify NBAF This is to answer #372 * Update BS_SD.adoc
This is to close #373.
* Optional PAD AVA_VAN This is to close #374 * Update Supporting Documents/BS_SD.adoc Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov> Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov>
* PAD optional This is to close #375. * Update Supporting Documents/BS_SD.adoc Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov> Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov>
* Testing week justfication This is to close #377. * Update Supporting Documents/BS_SD.adoc Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov> * Update BS_SD.adoc Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov>
* Quality assessment update This is to close #368 and close #369. * update from call Update based on the call discussion * Update Supporting Documents/BS_SD.adoc Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov> * Update Supporting Documents/BS_SD.adoc Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov> Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov>
* memory dump update To respond to #370 * Update BS_SD.adoc modification to look for template header data (which should be easier to find instead of trying to make something to dump a specific scan to external storage) and let scans occur at any time, before/during/after as possible by the lab * updates based on call This updates to remove the memory test as out of scope as it is testing the SEE boundary, and not the TOE boundary. In line 597 there is a statement (which I left) about source code review being acceptable to ensure this as an alternative to testing (which I left specifically for the TSFI test). I don't want to make this a requirement for the general boundary issue (that everything is inside the SEE), but it is something to consider. * no TSFI outputs (based on memory dump changes) (#388) * no TSFI outputs (based on memory dump changes) This is to close #371. This new PR supercedes #387 due to the number of changes that were made in #380 that coincided with the changes for this topic. * local storage update * Update BS_SD.adoc
This is to close #378 This part includes the section 4.4 in the PP-Config as well as the additional reference of the Toolbox in the documents. In the SD this covers adding the toolbox to the list of supporting docs reference at the beginning (I made that into a table from the bullet list to make it a little more clear)
This is to make the SD match the updated toolbox in biometricITC/cPP-toolboxes#59
* adding IAPAR definition Added IAPAR definition in section 7 to respond to concerns about clarity of PAD testing. * Update BS_SD.adoc * Update Supporting Documents/BS_SD.adoc Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov> * Update BS_SD.adoc Co-authored-by: Greg Fiumara <gregory.fiumara@nist.gov>
This is just an update of the dates using the date of the last commit that was approved (prior to this one).
To match up with the PP_MDF release the following changes were made: - release dates for the docs all changed to match with the dates of the PP_MDF date (September 12, 2022) - The specific PP-Modules that are allowed was removed and replaced by a link to a new page on the website. This will prevent needing to revise the PPM every time NIAP publishes as new Module update as the website page can be done easily. - in the PP-Config (which will not be used as NIAP will create their own), I changed the reference to the PPM to MOD_BIO_V1.0 which matches the NIAP format for the names
correct titles
date and allowed list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Quick scope update to resolve issues raised on review.