Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use progress bar on download #40

Closed
Fohlen opened this issue Nov 3, 2017 · 5 comments
Closed

Use progress bar on download #40

Fohlen opened this issue Nov 3, 2017 · 5 comments

Comments

@Fohlen
Copy link

Fohlen commented Nov 3, 2017

It would be better to use a progress bar when downloading archives.
Only when using a --verbose flag all details should be printed to the console.

@Istar-Eldritch
Copy link
Member

Hi @Fohlen, I think I don't understand exactly what you mean. There is already a download progress bar when using the download subcommand. Where would you like to see this feature?

@Fohlen
Copy link
Author

Fohlen commented Nov 4, 2017

Hey @Istar-Eldritch for bionode-ncbi@2.0.1 on OSX High Sierra this is not exactly the case.
I do get all the file names and everything printed in my console when using the download subcommand.

@Istar-Eldritch
Copy link
Member

Interesting... Would you be able to provider a recording of the case? The output of https://asciinema.org/ or a gif recorder would come handy to see the reproduction details. I don't have a mac with me now but I'll try to reproduce it Monday.

@Fohlen
Copy link
Author

Fohlen commented Nov 5, 2017

Hey @Istar-Eldritch, have a look here
https://asciinema.org/a/dq6MNldxau5fBMXrJL5AdbgRl

This ofc goes on and on for the entire archive 🚀

@Istar-Eldritch
Copy link
Member

Istar-Eldritch commented Nov 5, 2017

Thank you very much for the video. :)

If you add the --pretty flag you should get the expected progress bar:
bionode-ncbi download assembly human --pretty

Bionode benefits from its streaming capabilities, making it composable with other command line utilities through Unix pipes. In the case of download, I guess the decision of keeping the output in NDJSON by default was to keep the interface coherent with the behaviour of the rest of the CLI.

I hope this clarifies a bit your issue.

@bmpvieira bmpvieira added this to Backlog in Bionode Project Board Apr 6, 2018
@Fohlen Fohlen closed this as completed Jan 15, 2019
Bionode Project Board automation moved this from Backlog to Done Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants