-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new prefix: semapv #714
Conversation
@matentzn can you please check that this is all correct? Is this how we should be calling this, or should it be semapv_voc?
@matentzn can I add your email address to be associated as the contact person? Do you have a preference which email to use? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small fixes, otherwise great.
}, | ||
"description": "The Semantic Mapping Vocabulary provides and defines terms used for creating and maintaining semantic mappings, in particular mapping metadata.", | ||
"download_owl": "https://raw.githubusercontent.com/mapping-commons/semantic-mapping-vocabulary/main/semapv.owl", | ||
"example": "BackgroundKnowledgeBasedMatching", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"example": "BackgroundKnowledgeBasedMatching", | |
"example": "LexicalMatching", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easier to comprehend example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can add multiple examples if you prefer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its fine, multiple examples also mean more maintenance.. I think the linked documentation is the most important!
"download_owl": "https://raw.githubusercontent.com/mapping-commons/semantic-mapping-vocabulary/main/semapv.owl", | ||
"example": "BackgroundKnowledgeBasedMatching", | ||
"homepage": "https://mapping-commons.github.io/semantic-mapping-vocabulary/", | ||
"license": "CC-BY-4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"license": "CC-BY-4.0", | |
"license": "CC-0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hella
"github": "matentzn", | ||
"name": "Nico Matentzoglu", | ||
"orcid": "0000-0002-7356-1779", | ||
"email": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"email": "" | |
"email": "nicolas.matentzoglu@gmail.com" |
Co-Authored-By: Nico Matentzoglu <7070631+matentzn@users.noreply.github.com>
Co-Authored-By: Nico Matentzoglu <7070631+matentzn@users.noreply.github.com>
Codecov ReportBase: 39.33% // Head: 39.33% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
=======================================
Coverage 39.33% 39.33%
=======================================
Files 132 132
Lines 7434 7434
Branches 1715 1715
=======================================
Hits 2924 2924
Misses 4335 4335
Partials 175 175
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closes mapping-commons/semantic-mapping-vocabulary#5.
@matentzn can you please check that this is all correct? Is this how we should be calling this, or should it be semapv_voc?
Also somehow I thought we added this before...