Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new prefix: semapv #714

Merged
merged 7 commits into from
Jan 30, 2023
Merged

Add new prefix: semapv #714

merged 7 commits into from
Jan 30, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Jan 29, 2023

Closes mapping-commons/semantic-mapping-vocabulary#5.

@matentzn can you please check that this is all correct? Is this how we should be calling this, or should it be semapv_voc?

Also somehow I thought we added this before...

@matentzn can you please check that this is all correct? Is this how we should be calling this, or should it be semapv_voc?
@cthoyt
Copy link
Member Author

cthoyt commented Jan 29, 2023

@matentzn can I add your email address to be associated as the contact person? Do you have a preference which email to use?

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small fixes, otherwise great.

},
"description": "The Semantic Mapping Vocabulary provides and defines terms used for creating and maintaining semantic mappings, in particular mapping metadata.",
"download_owl": "https://raw.githubusercontent.com/mapping-commons/semantic-mapping-vocabulary/main/semapv.owl",
"example": "BackgroundKnowledgeBasedMatching",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"example": "BackgroundKnowledgeBasedMatching",
"example": "LexicalMatching",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier to comprehend example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add multiple examples if you prefer!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine, multiple examples also mean more maintenance.. I think the linked documentation is the most important!

"download_owl": "https://raw.githubusercontent.com/mapping-commons/semantic-mapping-vocabulary/main/semapv.owl",
"example": "BackgroundKnowledgeBasedMatching",
"homepage": "https://mapping-commons.github.io/semantic-mapping-vocabulary/",
"license": "CC-BY-4.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"license": "CC-BY-4.0",
"license": "CC-0",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hella

"github": "matentzn",
"name": "Nico Matentzoglu",
"orcid": "0000-0002-7356-1779",
"email": ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"email": ""
"email": "nicolas.matentzoglu@gmail.com"

cthoyt and others added 4 commits January 30, 2023 11:41
Co-Authored-By: Nico Matentzoglu <7070631+matentzn@users.noreply.github.com>
Co-Authored-By: Nico Matentzoglu <7070631+matentzn@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Base: 39.33% // Head: 39.33% // No change to project coverage 👍

Coverage data is based on head (0d99336) compared to base (52604be).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   39.33%   39.33%           
=======================================
  Files         132      132           
  Lines        7434     7434           
  Branches     1715     1715           
=======================================
  Hits         2924     2924           
  Misses       4335     4335           
  Partials      175      175           
Impacted Files Coverage Δ
src/bioregistry/version.py 68.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request semapv prefix from bioregistry
3 participants