Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support individual gapped sequences for pairwise alignment #2632

Closed
Ellmen opened this issue Feb 5, 2020 · 3 comments
Closed

Support individual gapped sequences for pairwise alignment #2632

Ellmen opened this issue Feb 5, 2020 · 3 comments
Assignees

Comments

@Ellmen
Copy link

Ellmen commented Feb 5, 2020

Currently, the PairwiseAlignment class does not allow you to get the gapped sequences individually. This makes it hard to grab the sequences to, for instance, store them as a specified filetype.

There could be gapped_target() and gapped_query() functions that return these sequences. These functions could also be used when generating the formatted string. It would also be helpful to directly save a pairwise alignment as a fasta or something but that could wait for another ticket.

I'm happy to take a stab at this if you think it makes sense.

https://github.com/biopython/biopython/blob/master/Bio/Align/__init__.py

@mdehoon
Copy link
Contributor

mdehoon commented Feb 5, 2020

@Ellmen It makes sense; I am happy to look at your proposed code. Probably it makes most sense if gapped_target and gapped_query return a string instead of a Seq object. Also, we may merge the PairwiseAlignment and MultipleSeqAlignment classes at some point, so it may be better to have a single function or attribute that takes an index (0 or 1 for now) instead of target/query.

@Ellmen
Copy link
Author

Ellmen commented Feb 6, 2020

@mdehoon great, I'll try to get to that today. I like the idea of merging the pairwise and MSA classes 👍

@mdehoon
Copy link
Contributor

mdehoon commented Jun 10, 2021

@Ellmen I believe this issue has been fixed by #3565 (which is in Biopython release 1.79). Please reopen this issue if it hasn't been solved.

@mdehoon mdehoon closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants