Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubsMat.MatrixInfo update #282

Closed
biologyguy opened this issue Feb 7, 2014 · 8 comments
Closed

SubsMat.MatrixInfo update #282

biologyguy opened this issue Feb 7, 2014 · 8 comments

Comments

@biologyguy
Copy link
Contributor

I've updated Bio.SubsMat.MatrixInfo.py with a new substitution matrix (PHAT) and written a little function to output the matrices in a more useable format. I've been using the new version for months, and figured I should polish it up and submit it to be included in the official package. Anyone interested in taking a look?
-Steve

@peterjc
Copy link
Member

peterjc commented Feb 8, 2014

That sounds potential quite useful - you're talking about this paper?

Ng et al (2000) PHAT: a transmembrane-specific substitution matrix.
http://dx.doi.org/10.1093/bioinformatics/16.9.760

It looks like the URL in their abstract is dead, http://www.blocks.fhcrc.org/~pauline - but at least their PHAT 55/73 matrix was given in Figure 3. I've only skimmed the paper but it sounds like they also made some variants.

On the technical side, I would suggest you prepare the new PHAT matrix (this is probably the more straightforward part), and the output bit (these is where I expect more feedback/suggestions on the proposed interface) as separate commits (or even separate pull requests?). Hopefully someone working more closely with substitution matrices can comment:
http://lists.open-bio.org/pipermail/biopython-dev/2014-February/011067.html

@biologyguy
Copy link
Contributor Author

Hi Peter,
The Ng et al., paper is indeed the one that I extracted the values from, and I've actually included the SLIM161 matrix as well (from dx.doi.org/10.1093/bioinformatics/17.suppl_1.S182). I haven't looked into implementing the algorithms to generate these matrices de novo, so I don't have easy access to variants (I suppose I could try to track down the authors).
-Steve

@peterjc
Copy link
Member

peterjc commented Feb 9, 2014

The finished static matrices should be useful on their own.

@biologyguy
Copy link
Contributor Author

Okay Peter,
I've added a new pull request. This is essentially my first time using Git, so hopefully I've done everything correctly.
There are two commits in the pull request, as you suggested (I wasn't sure about sending in two different pull requests, hopefully this is okay). The first is just the matrices, and the second is the new function.
-Steve

@peterjc
Copy link
Member

peterjc commented Feb 10, 2014

Closed in favour of #283

@pledor
Copy link

pledor commented Mar 11, 2014

Hi,
I'm interested!
Where can I download it?

@peterjc
Copy link
Member

peterjc commented Mar 11, 2014

You can find the updated code on pull request #283, linked to here and in the preceding comment.

@pledor
Copy link

pledor commented Mar 11, 2014

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants