setup env to cope with OSX compiler flag issue #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand it's not a great long term fix but it got me up and running. |
|
I would prefer to add the flag to any preexisting C or C++ compiler flags, rather than blindly overwriting any prior value, but otherwise this was what I was suggesting as a workaround. |
peterjc
added a commit
that referenced
this pull request
May 26, 2014
This is a workaround for Apple's incompatible Python & Clang releases, using the C/C++ compiler environment variables to add -Qunused-arguments to silence the clang error. Closes issue #325.
|
Could you try the code from the master branch please? Specifically this commit 2ceecab which should only alter the environment variables if Clang is being used - and not override any user specified compiler flags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #324 to allow "python setup.py install" to work on OSX. Uses the suggestions from http://lists.open-bio.org/pipermail/biopython-dev/2014-April/011240.html to patch setup.