Testing #35

bilalshaikh42 · 2019-10-16T04:12:47Z

Fix for #9
Fixes all tests to make them pass
Does not actually include needed tests for all components

todo · 2019-10-16T04:12:50Z

The alert component needs to be mocked!

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/e81d921e20a9e0871209d5d1ce182d37c7422250/CRBM-Viz/src/app/Components/past-simulation/past-simulation.component.spec.ts#L9-L14

This comment was generated by todo based on a `TODO` comment in `e81d921` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-16T04:27:35Z

change this import to simply import the app-material module?

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/289b0661236b38585a5d319049590992a20aa27f/CRBM-Viz/src/app/Components/new-simulation/new-simulation.component.spec.ts#L6-L11

This comment was generated by todo based on a `TODO` comment in `289b066` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-16T04:27:38Z

The alert component needs to be mocked !

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/289b0661236b38585a5d319049590992a20aa27f/CRBM-Viz/src/app/Components/new-simulation/new-simulation.component.spec.ts#L10-L15

This comment was generated by todo based on a `TODO` comment in `289b066` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-16T20:44:48Z

this test is failing due to error in component

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/98fdcfa37ff2f487d478d8157a3307f359f4ad3a/CRBM-Viz/src/app/Pages/files/file-edit/file-edit.component.spec.ts#L11-L16

This comment was generated by todo based on a `TODO` comment in `98fdcfa` in #35. cc @reproducible-biomedical-modeling.

bilalshaikh42 · 2019-10-16T20:50:00Z

this test is failing due to error in component

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/98fdcfa37ff2f487d478d8157a3307f359f4ad3a/CRBM-Viz/src/app/Pages/files/file-edit/file-edit.component.spec.ts#L11-L16

This comment was generated by todo based on a TODO comment in 98fdcfa in #35. cc @reproducible-biomedical-modeling.

@gmarupilla Could you take a look at the tests for this component?

gmarupilla · 2019-10-16T20:56:19Z

this test is failing due to error in component

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/98fdcfa37ff2f487d478d8157a3307f359f4ad3a/CRBM-Viz/src/app/Pages/files/file-edit/file-edit.component.spec.ts#L11-L16

This comment was generated by todo based on a TODO comment in 98fdcfa in #35. cc @reproducible-biomedical-modeling.

@gmarupilla Could you take a look at the tests for this component?

Let me look into that!

todo · 2019-10-16T21:37:44Z

The indiviudal components should be mocked

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/b796175f212350071b0510c7fd686e7c201e5c71/CRBM-Viz/src/app/Layout/navigation/navigation.component.spec.ts#L4-L9

This comment was generated by todo based on a `TODO` comment in `b796175` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-16T21:37:47Z

Sample content is needed and component compiled with it as input for <ng-content>

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/b796175f212350071b0510c7fd686e7c201e5c71/CRBM-Viz/src/app/Layout/navigation/navigation.component.spec.ts#L13-L18

This comment was generated by todo based on a `TODO` comment in `b796175` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-16T22:07:33Z

Mock the alert component

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/b7be39b71e973981f25c5d2aadf9254c776e52e0/CRBM-Viz/src/app/Pages/simulate/simulate.component.spec.ts#L6-L11

This comment was generated by todo based on a `TODO` comment in `b7be39b` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-16T22:07:37Z

create mock vega view

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/b7be39b71e973981f25c5d2aadf9254c776e52e0/CRBM-Viz/src/app/Pages/visualize/visualize.component.spec.ts#L8-L13

This comment was generated by todo based on a `TODO` comment in `b7be39b` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-16T22:07:39Z

mock http client request for spec

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/b7be39b71e973981f25c5d2aadf9254c776e52e0/CRBM-Viz/src/app/Pages/visualize/visualize.component.spec.ts#L9-L14

This comment was generated by todo based on a `TODO` comment in `b7be39b` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-16T22:29:49Z

Sample content is needed and component compiled with it as input for <ng-content>

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/23c5842c737de9d4b704ccd5b645a5500ff32d47/CRBM-Viz/src/app/Layout/navigation/navigation.component.spec.ts#L13-L18

This comment was generated by todo based on a `TODO` comment in `23c5842` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-17T14:50:58Z

Sample content is needed and component compiled with it as input for <ng-content>

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/c191d8554fc07a167d9df0e155c5aa1ea9e430e0/CRBM-Viz/src/app/Layout/navigation/navigation.component.spec.ts#L13-L18

This comment was generated by todo based on a `TODO` comment in `c191d85` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-17T15:35:36Z

this test causes the next test to fail due to missing alertcomponent factory

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/9990812697ca6b0d1c64faa445e907e7e1b21055/CRBM-Viz/src/app/Components/new-simulation/new-simulation.component.spec.ts#L12-L17

This comment was generated by todo based on a `TODO` comment in `9990812` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-17T15:35:39Z

this test causes the next test to fail due to missing alertcomponent factory

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/9990812697ca6b0d1c64faa445e907e7e1b21055/CRBM-Viz/src/app/Components/past-simulation/past-simulation.component.spec.ts#L11-L16

This comment was generated by todo based on a `TODO` comment in `9990812` in #35. cc @reproducible-biomedical-modeling.

todo · 2019-10-17T15:35:42Z

Sample content is needed and component compiled with it as input for <ng-content>

https://github.com/reproducible-biomedical-modeling/CRBM-Viz/blob/9990812697ca6b0d1c64faa445e907e7e1b21055/CRBM-Viz/src/app/Layout/navigation/navigation.component.spec.ts#L13-L18

This comment was generated by todo based on a `TODO` comment in `9990812` in #35. cc @reproducible-biomedical-modeling.

bilalshaikh42 added 7 commits October 15, 2019 16:48

Fixed bad imports

2944dd4

Cleaned up imports

fdae47e

Added custom_elements_schema for tests

1b22b3f

Fixed link component test

f48c774

Fixed Profile tests

1fd7cf8

Fixed past-simulation tests

bd52758

Add todo bot config

e81d921

bilalshaikh42 added this to High priority in Bugs Oct 16, 2019

bilalshaikh42 added 2 commits October 16, 2019 00:16

Fixed New Simulation component tests

19f6482

Add todos

289b066

bilalshaikh42 added 6 commits October 16, 2019 15:27

Fixed File Edit tests

b800b64

Fixed Upload Test

6b11ea0

Fixed Alert component tests

605cbf3

Fixed Alert Service test

1419ca8

Fixed File Table testing

383700c

Fixed Search bar component tests

98fdcfa

Fixed navigation test

b796175

bilalshaikh42 added 5 commits October 16, 2019 17:39

Fixed Auth0 service tests

0e0c864

Fixed Gaurds Test

a8a725c

Fixed simulate component tests

0823d11

Fixed visualize components test

3b2e7c4

Fixed callback temporarily

b7be39b

bilalshaikh42 added 2 commits October 16, 2019 18:15

lint fix

df98019

Added automatic pre-commit linting

23c5842

bilalshaikh42 marked this pull request as ready for review October 16, 2019 22:36

bilalshaikh42 requested a review from gmarupilla October 16, 2019 22:36

bilalshaikh42 added 2 commits October 17, 2019 10:21

Skip file edit test

92c942e

Fixed vega-viewer test

c191d85

Disabling tests that cause nondeterministic behavior

9990812

bilalshaikh42 merged commit 1b71baf into master Oct 17, 2019

Bugs automation moved this from High priority to Closed Oct 17, 2019

bilalshaikh42 mentioned this pull request Oct 17, 2019

Tests are failing #9

Closed

bilalshaikh42 deleted the testing branch October 29, 2019 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Testing #35

Testing #35

bilalshaikh42 commented Oct 16, 2019

todo bot commented Oct 16, 2019

todo bot commented Oct 16, 2019

todo bot commented Oct 16, 2019

todo bot commented Oct 16, 2019

bilalshaikh42 commented Oct 16, 2019

this test is failing due to error in component

This comment was generated by todo based on a `TODO` comment in 98fdcfa in #35. cc @reproducible-biomedical-modeling.

gmarupilla commented Oct 16, 2019

this test is failing due to error in component

This comment was generated by todo based on a `TODO` comment in 98fdcfa in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

todo bot commented Oct 16, 2019

todo bot commented Oct 16, 2019

todo bot commented Oct 16, 2019

todo bot commented Oct 16, 2019

todo bot commented Oct 16, 2019

todo bot commented Oct 17, 2019

todo bot commented Oct 17, 2019

todo bot commented Oct 17, 2019

todo bot commented Oct 17, 2019

Testing #35

Testing #35

Conversation

bilalshaikh42 commented Oct 16, 2019

todo bot commented Oct 16, 2019

The alert component needs to be mocked!

This comment was generated by todo based on a TODO comment in e81d921 in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

change this import to simply import the app-material module?

This comment was generated by todo based on a TODO comment in 289b066 in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

The alert component needs to be mocked !

This comment was generated by todo based on a TODO comment in 289b066 in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

this test is failing due to error in component

This comment was generated by todo based on a TODO comment in 98fdcfa in #35. cc @reproducible-biomedical-modeling.

bilalshaikh42 commented Oct 16, 2019

this test is failing due to error in component

This comment was generated by todo based on a TODO comment in 98fdcfa in #35. cc @reproducible-biomedical-modeling.

gmarupilla commented Oct 16, 2019

this test is failing due to error in component

This comment was generated by todo based on a TODO comment in 98fdcfa in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

The indiviudal components should be mocked

This comment was generated by todo based on a TODO comment in b796175 in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

Sample content is needed and component compiled with it as input for <ng-content>

This comment was generated by todo based on a TODO comment in b796175 in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

Mock the alert component

This comment was generated by todo based on a TODO comment in b7be39b in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

create mock vega view

This comment was generated by todo based on a TODO comment in b7be39b in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

mock http client request for spec

This comment was generated by todo based on a TODO comment in b7be39b in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 16, 2019

Sample content is needed and component compiled with it as input for <ng-content>

This comment was generated by todo based on a TODO comment in 23c5842 in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 17, 2019

Sample content is needed and component compiled with it as input for <ng-content>

This comment was generated by todo based on a TODO comment in c191d85 in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 17, 2019

this test causes the next test to fail due to missing alertcomponent factory

This comment was generated by todo based on a TODO comment in 9990812 in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 17, 2019

this test causes the next test to fail due to missing alertcomponent factory

This comment was generated by todo based on a TODO comment in 9990812 in #35. cc @reproducible-biomedical-modeling.

todo bot commented Oct 17, 2019

Sample content is needed and component compiled with it as input for <ng-content>

This comment was generated by todo based on a TODO comment in 9990812 in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `e81d921` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `289b066` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `289b066` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `98fdcfa` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in 98fdcfa in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in 98fdcfa in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `b796175` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `b796175` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `b7be39b` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `b7be39b` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `b7be39b` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `23c5842` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `c191d85` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `9990812` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `9990812` in #35. cc @reproducible-biomedical-modeling.

This comment was generated by todo based on a `TODO` comment in `9990812` in #35. cc @reproducible-biomedical-modeling.