Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cross repo app adjustments #4734

Merged
merged 19 commits into from
Jul 31, 2023
Merged

feat: cross repo app adjustments #4734

merged 19 commits into from
Jul 31, 2023

Conversation

AlexPatrie
Copy link
Collaborator

What new features does this PR implement?
Please summarize the features that this PR implements. As relevant, please indicate the issues that the PR closes.

  • style(ui): removes biosimulations-icon from inner hero banner app components in simulators
  • fix: fixes visual layout of transparent dropdown menus in both simulators and dispatch
  • chore: ensures correct routing both internally and externally amongst dev and prod

@nx-cloud
Copy link

nx-cloud bot commented Jul 28, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 475d6ce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@AlexPatrie AlexPatrie marked this pull request as ready for review July 28, 2023 17:23
@AlexPatrie AlexPatrie marked this pull request as draft July 28, 2023 17:24
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@eagmon eagmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AlexPatrie!

@AlexPatrie AlexPatrie marked this pull request as ready for review July 31, 2023 17:03
@AlexPatrie AlexPatrie merged commit 4dc953c into dev Jul 31, 2023
21 checks passed
@AlexPatrie AlexPatrie deleted the app-adjustments branch July 31, 2023 17:06
@biosimulations-daemon
Copy link
Collaborator

🎉 This PR is included in version 9.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants