Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data #66

Merged
merged 12 commits into from
Oct 29, 2019
Merged

Data #66

merged 12 commits into from
Oct 29, 2019

Conversation

bilalshaikh42
Copy link
Member

Add components and page for displaying tabular data

@bilalshaikh42 bilalshaikh42 added this to In progress in Visualization via automation Oct 21, 2019
@todo
Copy link

todo bot commented Oct 22, 2019

@bilalshaikh42 bilalshaikh42 marked this pull request as ready for review October 29, 2019 16:57
@bilalshaikh42
Copy link
Member Author

@gmarupilla You can go ahead and merge this in if you agree with changes!
It provides a new data-table component that can be used for any situation where we need to display tabular data. It might be worth switching this over to the built-in data table, but that will take some work as we would need to build all the included features manually.

@gmarupilla
Copy link
Contributor

@gmarupilla You can go ahead and merge this in if you agree with changes!
It provides a new data-table component that can be used for any situation where we need to display tabular data. It might be worth switching this over to the built-in data table, but that will take some work as we would need to build all the included features manually.

Yes! I could definitely merge and you can switch to mat-tables later.

@gmarupilla gmarupilla merged commit 21f08b2 into master Oct 29, 2019
Visualization automation moved this from In progress to Done Oct 29, 2019
@bilalshaikh42 bilalshaikh42 deleted the data branch October 29, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Visualization
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants