Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP-refactoring nesting #57

Closed
wants to merge 23 commits into from
Closed

WIP-refactoring nesting #57

wants to merge 23 commits into from

Conversation

AlexPatrie
Copy link
Contributor

In an effort to lower the generalized "cognitive complexity" score assessed by SonarCloud, this pr and branch serves as an effort to lower all cognitive complexity-assessments-points > 1 to be <= 0. Please refer to Issue "Lowering Cognitive complexity as per SonarCloud" for more information.

…Cloud Bot to be above the acceptable threshold for cognitive complexity.
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexPatrie AlexPatrie linked an issue Apr 18, 2023 that may be closed by this pull request
@AlexPatrie AlexPatrie requested a review from eagmon April 18, 2023 18:30
Copy link

@eagmon eagmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @AlexPatrie! sorry for the delayed approval. This looks ready to merge. For the future: change the PR to a non-draft PR when you're ready to merge.

@fbergmann
Copy link
Collaborator

@AlexPatrie @eagmon is this PR still about to be applied? We were informed about the biosimulator not solving simple SBML problems. So I was about to look into this, but would not want to change code if this PR is about to be merged in.

Critically there is an issue merging in the changes for the identifiers.org parts, where you are planing to commit a change from

http://identifiers.org/combine.specifications/sbml

to

https://identifiers.org/combine.specifications/sbml

this should not happen, since http://identifiers.org/combine.specifications/sbml is a namespace, and the https version would be a different namespace. So if this PR is going to merge, then that should not be merged in.

@AlexPatrie
Copy link
Contributor Author

@AlexPatrie @eagmon is this PR still about to be applied? We were informed about the biosimulator not solving simple SBML problems. So I was about to look into this, but would not want to change code if this PR is about to be merged in.

Critically there is an issue merging in the changes for the identifiers.org parts, where you are planing to commit a change from

http://identifiers.org/combine.specifications/sbml

to

https://identifiers.org/combine.specifications/sbml

this should not happen, since http://identifiers.org/combine.specifications/sbml is a namespace, and the https version would be a different namespace. So if this PR is going to merge, then that should not be merged in.

Hi @fbergmann! This is an outdated PR that I should have originally archived. Please feel free to do whatever work you need here. I will be closing this PR.

@AlexPatrie AlexPatrie closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Lowering Cognitive complexity as per SonarCloud
3 participants